DM-11473: Add SpherePoint(long, lat, unit) constructor #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove SpherePoint(double const lonLatRad[2]) constructor.
kfindeisen
approved these changes
Oct 4, 2017
tests/test_spherePoint.py
Outdated
| @@ -128,6 +128,14 @@ def testCopyConstructor(self): | |||
| spcopy = SpherePoint(sp) | |||
| self.assertEqual(sp, spcopy) | |||
|
|
|||
| def testDoubleConstructor(self): | |||
There was a problem hiding this comment.
DoubleConstructor is potentially ambiguous. Maybe SharedUnitConstructor?
kfindeisen
requested changes
Oct 4, 2017
| @@ -63,7 +63,8 @@ Angle haversine(Angle const& deltaLon, Angle const& deltaLat, double cosLat1, do | |||
| } | |||
| } // end namespace | |||
|
|
|||
| SpherePoint::SpherePoint(double const lonLatRad[2]) : _longitude(lonLatRad[0]), _latitude(lonLatRad[1]) {} | |||
| SpherePoint::SpherePoint(double longitude, double latitude, AngleUnit units) | |||
| : _longitude(longitude * units), _latitude(latitude * units) {} | |||
There was a problem hiding this comment.
I can't believe I overlooked this: please add input validation for longitude and latitude (as implied by the documentation) and test it. The easiest way to implement input validation is to delegate to the (Angle, Angle) constructor.
There was a problem hiding this comment.
Sorry I missed this the first time. I'll add shortly it in a new ticket.
r-owen
force-pushed
the
tickets/DM-11473
branch
from
0b68089
to
4934e7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.