DM-8015 add operator<< and __str__ for VisitInfo #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
approved these changes
Oct 31, 2017
| std::stringstream os; | ||
| os << self; | ||
| return os.str(); | ||
| }); |
There was a problem hiding this comment.
I suggest you add an import of <sstream> with the other system imports
| @@ -47,7 +47,7 @@ namespace { | |||
| static double const nan(std::numeric_limits<double>::quiet_NaN()); | |||
| static geom::Angle const nanAngle(nan); | |||
|
|
|||
| } // anonymous | |||
| } // namespace | |||
There was a problem hiding this comment.
Please consider moving the clang-formatting changes to the previous commit, since they really don't seem to be relevant to the important changes.
parejkoj
force-pushed
the
tickets/DM-8015
branch
from
4440475
to
b385a03
Compare
parejkoj
force-pushed
the
tickets/DM-8015
branch
from
b385a03
to
4e8fa52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.