Point2I __repr__ reported wrong type.

[SimonKrughoff]

No description provided.

[TallJimbo]

Might be slightly better to write this as e.g. assertIs(box.Point, geom.Point2I).

[SimonKrughoff]

So the problem is that box.Point is some sort of pybind11 wrapper type. I could say self.assertIs(box.Point(), geom.Point2I). Is that acceptable?

[kfindeisen]

Can you elaborate? Type comparisons should Just Work for pybind11 wrappers.

[timj]

Is the point that we always prefer a specific test method over assertTrue?

[SimonKrughoff]

@timj I think we should prefer specific tests if we can.

@kfindeisen This is what I'm seeing. I didn't know if I should expect this or not. The fact that the Point on a Box2I is a Point2D is the bug I'm trying to fix in this ticket.

>>> box = afwGeom.Box2I()
>>> box.Point
<class 'lsst.afw.geom.coordinates.coordinates.Point2D'>
>>> type(box.Point)
<class 'pybind11_builtins.pybind11_type'>
>>> type(box.Point) is afwGeom.Point2D
False

[kfindeisen]

box.Point should be a class object, so the last line makes sense. Is box.Point is afwGeom.Point2D also false? What about box.Point == afwGeom.Point2D?

[SimonKrughoff]

In python2

>>> box = afwGeom.Box2I()
>>> box.Point
<class 'lsst.afw.geom.coordinates.coordinates.Point2D'>
>>> type(box.Point)
<class 'pybind11_type'>

[SimonKrughoff]

Very interesting:

>>> box = afwGeom.Box2I()
>>> box.Point is afwGeom.Point2D
True
>>> box.Point == afwGeom.Point2D
True

Looks like I can say:
self.assertIs(box.Point, afwGeom.Point2D)