DM-9953: Pixels rejected from coaddition and CCD are not masked on coadds #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Nov 20, 2017
| img.getMask().set(0) | ||
| stack = afwMath.statisticsStack(images, afwMath.MEANCLIP, clipped=clipped) | ||
| self.assertFloatsAlmostEqual(stack.getImage().getArray(), 0.0, atol=0.0) | ||
| self.assertFloatsAlmostEqual(stack.getMask().getArray(), 0, atol=0.0) # Not floats, but that's OK |
There was a problem hiding this comment.
There's a forwarding method for exactly this: assertFloatsEqual.
We want to know the number of inputs that were clipped in the process of measuring the clipped statistics (e.g., MEANCLIP).
It's helpful to know the number of inputs that were masked, and it's inexpensive to calculate.
We want to know when a pixel is clipped or masked (because on coadds that means the CoaddPsf won't be accurate), so have a bit set when this occurs. Uses the new NCLIPPED and NMASKED statistics. Some mask bits may be excused from triggering this, so as not to mask as clipped/masked pixels that shouldn't ever be considered for inclusion in the stack (e.g., NO_DATA; as opposed to pixels that are not being included because the are in the imaged area but corrupted somehow).
PaulPrice
force-pushed
the
tickets/DM-9953
branch
from
80253c0
to
ae2985a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.