Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-12764: Overhaul SkyWcs #294

Merged
merged 32 commits into from
Dec 13, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
edb784a
Fix bug in assertCoordListsAlmostEqual
r-owen Nov 3, 2017
babad4d
Fix typo in Transform.h
r-owen Aug 4, 2017
e33ec44
Remove obsolete comment from SpherePoint.h
r-owen Dec 5, 2017
0e1022d
Fix documentation of makePixelToTanPixel
r-owen Dec 4, 2017
01ecc3f
Add note about units to Transform.getJacobian doc
r-owen Oct 18, 2017
6e257c3
Simplify a test in test_transform.py
r-owen Sep 15, 2017
a0590cd
Fix warning in test_wcsFitsTable.py
r-owen Oct 13, 2017
3b0372a
Use TransformPoint2ToPoint2 typedef
r-owen Oct 10, 2017
26c8fea
Add `simplify=true` argument to Transform::then
r-owen Sep 15, 2017
6c8502b
Remove unused var in ostream operator<<(Transform)
r-owen Sep 29, 2017
f71d602
Standardize comment style in Endpoint.h and Transform.h
r-owen Dec 8, 2017
c6963fe
Fix comment in transform.cc
r-owen Apr 26, 2017
8e42d93
Endpoint: refine comment
r-owen Dec 8, 2017
d02785a
Add addPersistableMethods to table/io/python.h
r-owen Dec 7, 2017
3bab58e
Modernize wrapping of table persistence
r-owen Dec 7, 2017
cee5b52
Remove table.io import from photoCalib.cc
r-owen Dec 8, 2017
9dba51f
Hoist Ellipse, Quadrupole and polygon symbols into lsst.afw.geom
r-owen Dec 7, 2017
a4f6bea
Transform: member functions return shared_ptr
r-owen Nov 29, 2017
c06f8a6
Import astropy.io.fits instead of astropy.io
r-owen Oct 4, 2017
70b05b5
Document override getPythonModule in Persistable
r-owen Oct 12, 2017
6932b6a
Enhance formatFitsProperties
r-owen Nov 20, 2017
29dc11a
Fix documentation of warpImage
r-owen Dec 4, 2017
f93a35d
Add TransformPoint2ToPoint2 support to Polygon
r-owen Oct 11, 2017
1b3ee89
Simplify import of Ellipse, Polygon, Quadrupole
r-owen Dec 11, 2017
e2393f9
Add geom wcsUtils
r-owen Dec 8, 2017
c255d26
Expand geom/testUtils.py
r-owen Nov 21, 2017
a35f8db
Overhaul WCS-related functions in frameSetUtils
r-owen Sep 14, 2017
6aac285
Make Transform `final`
r-owen Dec 4, 2017
8d67bab
Transform: simplify shared_ptr constructor
r-owen Dec 4, 2017
1d2ea93
Make functions return shared_ptr<Transform>
r-owen Dec 4, 2017
55d4a10
Clean up imports in transformFactory.cc
r-owen Dec 8, 2017
d786b0e
Overhaul SkyWcs
r-owen Dec 13, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/lsst/afw/cameraGeom/Orientation.h
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class Orientation {
*
* @returns lsst::afw::geom::Transform from pixel to focal plane coordinates
*/
geom::Transform<geom::Point2Endpoint, geom::Point2Endpoint> makePixelFpTransform(
std::shared_ptr<geom::TransformPoint2ToPoint2> makePixelFpTransform(
geom::Extent2D const pixelSizeMm ///< Size of the pixel in mm in X and Y
) const;

Expand All @@ -96,7 +96,7 @@ class Orientation {
*
* @returns lsst::afw::geom::Transform from focal plane to pixel coordinates
*/
geom::Transform<geom::Point2Endpoint, geom::Point2Endpoint> makeFpPixelTransform(
std::shared_ptr<geom::TransformPoint2ToPoint2> makeFpPixelTransform(
geom::Extent2D const pixelSizeMm ///< Size of the pixel in mm in X and Y
) const;

Expand Down
15 changes: 3 additions & 12 deletions include/lsst/afw/formatters/Utils.h
Original file line number Diff line number Diff line change
Expand Up @@ -152,23 +152,14 @@ This function is designed to format data for creating a WCS. It truncates long s
values and skips properties whose type it cannot handle.

@param[in] prop Properties to format
@param[in] excludeNames Names of properties to exclude from the returned string
@return a FITS header string (exactly 80 characters per "card", no line terminators)

@warning PropertySet is unordered, so the order of entries in the returned string is unpredictable.
*/
std::string formatFitsProperties(lsst::daf::base::PropertySet const& prop);
/**
Format a PropertyList into a FITS header string

This function is designed to format data for creating a WCS. It truncates long string
values and skips properties whose type it cannot handle.

@param[in] prop Properties to format
@param[in] excludeNames Names of properties to exclude from the returned string
@return a FITS header string (exactly 80 characters per "card", no line terminators)
*/
std::string formatFitsProperties(lsst::daf::base::PropertyList const& prop,
std::string formatFitsProperties(lsst::daf::base::PropertySet const& prop,
std::set<std::string> const& excludeNames = {});

int countFitsHeaderCards(lsst::daf::base::PropertySet const& prop);

/**
Expand Down