u/jbosch/DM-836 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be necessary to support FunctorKeys that return arrays.
|
The comments on lines 128 and 135 of arrays.h appear to be wrong. |
Good catch. Will fix. By the way, did you see that you can add comments like this directly on the lines of the diff in GitHub? That's actually the reason many of us like using GitHub for reviews so much. |
This lets us support implicit conversion in FunctorKey-based set.
mjuric
force-pushed
the
u/jbosch/DM-836
branch
from
d2ea707
to
caf672a
Compare
|
Added comments to the test code as requested, and rebased onto master. Will merge shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new FunctorKeys for arrays to afw::table, along with an expansion to the FunctorKey base class interfaces to support some of the things we can do with arrays that we couldn't do with any of the existing FunctorKeys (namely, return reference-like objects).