DM-13110: export magic value to select default HDU #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
force-pushed
the
tickets/DM-13110
branch
from
c620cd3
to
58add67
Compare
RobertLuptonTheGood
approved these changes
Jan 5, 2018
There was a problem hiding this comment.
This all looks good.
My apologies that I didn't do the export to python when I wrote the code (I don't think I knew pybind11 at the time, but that's not much of an excuse). Using DEFAULT_HDU not INT_MIN is a definite improvement, especially now that you're exporting the symbolic name.
We have used INT_MIN to indicate that the first non-empty HDU should be selected, but never exported the symbol to python. Changed the name (but kept the value) so it's clear what it is, and exported it to python.
PaulPrice
force-pushed
the
tickets/DM-13110
branch
from
58add67
to
d4e4976
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have used INT_MIN to indicate that the first non-empty HDU should
be selected, but never exported the symbol to python. Changed the name
(but kept the value) so it's clear what it is, and exported it to
python.