DM-13182: SpanSet.fromMask produces larger spans than image #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing SpanSet.fromMask(mask, 0xFF), the 'auto compareValue' is
inferred to be an integer ('pixel & maskVal' is an integer if there's
no '> 0') instead of a boolean, which violates the assumptions and
corrupts the 'runCounter'. Explicitly setting the type fixes it.
The use of 'runCounter' contributed to a bug (corrupting 'runCounter' because 'compareValue' wasn't a boolean). Instead, use a boolean to track whether we're in a span, and remember the starting value. This saves on the need to do arithmetic at Span creation time and simplifies the logic.
PaulPrice
force-pushed
the
tickets/DM-13182
branch
from
469277b
to
bcd5cb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.