DM-13084: Be smarter about combining metadata from FITS headers #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktlim
approved these changes
Jan 18, 2018
which combines property lists in a FITS-savvy fashion. This avoids turning scalars into lists and type mismatch errors when one value overrides another (a threat for LTV1, LVT2 if special measures are not taken elsewhere)
Make readMetadata call combineMetadata even if not combining metadata from two different HDUs so the user can rely on the returned data even if the header has invalid entries (e.g. non-string COMMENT or HISTORY cards, or repeated values of any other card).
r-owen
force-pushed
the
tickets/DM-13084
branch
from
46d498f
to
5f591ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.