DM-12995/RFC-436: Random: ensure seed is non-zero #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
force-pushed
the
tickets/DM-12995
branch
3 times, most recently
from
b9976d5
to
0d1685e
Compare
PaulPrice
force-pushed
the
tickets/DM-12995
branch
3 times, most recently
from
8b0cf77
to
b085c63
Compare
|
Correct, I have abandoned my original (stupid) plan and embraced @ktlim's sensible method. |
PaulPrice
force-pushed
the
tickets/DM-12995
branch
from
b085c63
to
27a6a78
Compare
Random has accepted a seed value of zero and then thrown an exception. This is not necessary, since we can simply use a non-zero seed value.
PaulPrice
force-pushed
the
tickets/DM-12995
branch
from
27a6a78
to
bf7488d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Random has accepted a seed value of zero and then thrown an exception.
This is not necessary, since we can construct a seed value that is
non-zero from whatever we're given.