Tickets/DM-13325: warpExposure does not propagate visitInfo #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
force-pushed
the
tickets/DM-13325
branch
from
b29902b
to
6bfeeea
Compare
r-owen
reviewed
Jan 25, 2018
include/lsst/afw/math/warpExposure.h
Outdated
| @@ -383,7 +383,7 @@ class WarpingControl { | |||
| template <typename DestExposureT, typename SrcExposureT> | |||
| int warpExposure( | |||
| DestExposureT &destExposure, ///< Remapped exposure. Wcs and xy0 are read, MaskedImage is set, | |||
| ///< and Calib and Filter are copied from srcExposure. | |||
| ///< and Calib, Filter, visitInfo, are copied from srcExposure. | |||
There was a problem hiding this comment.
I suggest putting "and" before visitInfo
r-owen
reviewed
Jan 25, 2018
tests/test_warpExposure.py
Outdated
| data.rotType, | ||
| data.observatory, | ||
| data.weather, | ||
| ) |
There was a problem hiding this comment.
I suggest you replace all this with the following and remove the earlier import of collections
def makeVisitInfo():
"""Return a non-NaN visitInfo."""
return afwImage.VisitInfo(exposureId=10313423,
exposureTime=10.01,
darkTime=11.02,
date=dafBase.DateTime(65321.1, dafBase.DateTime.MJD, dafBase.DateTime.TAI),
ut1=12345.1,
era=45.1*afwGeom.degrees,
boresightRaDec=afwCoord.IcrsCoord(23.1*afwGeom.degrees, 73.2*afwGeom.degrees),
boresightAzAlt=afwCoord.Coord(134.5*afwGeom.degrees, 33.3*afwGeom.degrees),
boresightAirmass=1.73,
boresightRotAngle=73.2*afwGeom.degrees,
rotType=afwImage.RotType.SKY,
observatory=afwCoord.Observatory(
11.1*afwGeom.degrees, 22.2*afwGeom.degrees, 0.333),
weather=afwCoord.Weather(1.1, 2.2, 34.5),
)
r-owen
approved these changes
Jan 25, 2018
Modify destExposure note to reflect new code
isullivan
force-pushed
the
tickets/DM-13325
branch
from
548d2ab
to
064b153
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.