DM-13396: Add more flexible mask propagation to statisticsStack. #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
approved these changes
Jan 29, 2018
src/math/Stack.cc
Outdated
| // Might the masking be excused? | ||
| image::MaskPixel const maskVal = sctrl.getAndMask() & ~excuse; | ||
| } | ||
| // Check to see if any pixels were rejected to be masking, and apply |
src/math/Stack.cc
Outdated
| template std::shared_ptr<image::MaskedImage<TYPE>> statisticsStack<TYPE>( \ | ||
| std::vector<std::shared_ptr<image::MaskedImage<TYPE>>> & images, Property flags, \ | ||
| StatisticsControl const &sctrl, WeightVector const &wvector, image::MaskPixel, \ | ||
| std::vector<std::pair<image::MaskPixel, image::MaskPixel>> const &); \ |
There was a problem hiding this comment.
Missing backslash in #define?
There was a problem hiding this comment.
Just bad whitespace, actually, but still worth fixing.
src/math/Stack.cc
Outdated
| template void statisticsStack<TYPE>( \ | ||
| image::MaskedImage<TYPE> & out, std::vector<std::shared_ptr<image::MaskedImage<TYPE>>> & images, \ | ||
| Property flags, StatisticsControl const &sctrl, WeightVector const &wvector, image::MaskPixel, \ | ||
| std::vector<std::pair<image::MaskPixel, image::MaskPixel>> const &); \ |
There was a problem hiding this comment.
Missing backslash in #define?
TallJimbo
force-pushed
the
tickets/DM-13396
branch
from
7cd263c
to
2a81816
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes here were done to in a way that should guarantee ABI compatibility with w_2018_04 (when the fixed version of that comes out); I didn't want anyone working on coadds this week to have to rebuild everything (instead they'll just have to rebuild afw). Note that this precludes some cleanups I'd have otherwise tried to do in nearby code (wow,
statisticsStackis a mess!).