afw review for DM-2929: re-enabling tests #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcs1.py and testSchema.py had some whitespace issues and unused code. This commit removes the whitespace and unused code.
A linter turned up some keys that were not tested. This led to adding a method for testing keys so that it is harder to miss testing newly added keys.
| @@ -133,32 +133,34 @@ def tearDown(self): | |||
| def makeWcs(self): | |||
| crval = afwCoord.Coord(afwGeom.Point2D(1.606631, 5.090329)) | |||
| crpix = afwGeom.Point2D(2036., 2000.) | |||
| wcs = afwImage.makeWcs(crval, crpix, 5.399452e-5, -1.30770e-5, 1.30770e-5, 5.399452e-5) | |||
| return afwImage.makeWcs(crval, crpix, 5.399452e-5, -1.30770e-5, 1.30770e-5, 5.399452e-5) | |||
There was a problem hiding this comment.
Looks like there's an extra space here.
The test that tests WCS flip and rotation was not enabled in the suite. This commit enables that test and fixes a bug in the WCS generation function where the wcs was created but not returned.
The methods that flip and rotate WCS objects had an off by one error. This commit fixes those methods and adds comments to describe the issue.
The test for rotation and flipping of WCS objects had an off by one error in the test positions (they were not being rotated/flipped correctly).
SimonKrughoff
force-pushed
the
tickets/DM-2929
branch
from
0805128
to
88896c4
Compare
SimonKrughoff
added a commit
that referenced
this pull request
Jul 2, 2015
afw review for DM-2929: re-enabling tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.