DM-13539: astshim fails to preserve SIP terms for some TAN SIP when writing FITS metadata #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine, especially with your comment in the commit about the better test existing in 10765. If you update that commit message to say what the better test is, you're good to merge. |
The test of SkyWcs.getTanWcs was only passing because TAN-SIP was not being written out by AST, a problem fixed on this ticket. For now remove the test for SkyWcs.getTanWcs(); tickets/DM-10765 has a much better test, but it relies on a function that that is not available on master. The new test is checkNonFitsWcs and it is called by testMakeModifiedWcsNoActualPixels and testMakeModifiedWcsWithActualPixels
r-owen
force-pushed
the
tickets/DM-13539
branch
from
aa2d068
to
669febe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test of SkyWcs.getTanWcs was only passing because TAN-SIP
was not being written out by AST, a problem fixed on this ticket.
For now remove the test for SkyWcs.getTanWcs();
tickets/DM-10765 has a much better test, but it relies on
a function that that is not available on master.