tickets/DM-3347 wcsNearlyEqual #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -92,12 +94,16 @@ def assertWcsNearlyEqualOverBBox(testCase, wcs0, wcs1, bbox, maxDiffSky=0.01*afw | |||
| diffSky = sky0.angularSeparation(sky1) | |||
| if diffSky > measDiffSky[0]: | |||
| measDiffSky = (diffSky, fromPixPos) | |||
| if doShortCircuit: | |||
| break | |||
There was a problem hiding this comment.
These breaks only exit one level. You need to break out of both levels.
There was a problem hiding this comment.
Good catch. I'll use itertools.product to make the for loop one level deep.
The assertX methods that afw presently adds to lsst_utils TestCase need only support fail(self, msgStr). Document this, and in one case make minor code changes to make it true. Also, start the doc strings with with """! instead of """ to make Doxygen pay attention to the Doxygen commands.
r-owen
force-pushed
the
tickets/DM-3347
branch
2 times, most recently
from
c89bba6
to
55d8bb9
Compare
Both the new wcsNearlyEqualOverBBox and the existing assertWcsNearlyEqualOverBBox are thin wrappers around a new private function _compareWcsOverBBox. Also add a unit test for wcsNearlyEqualOverBBox.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.