DM-13898: Remove the XYTransform classes #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fred3m
approved these changes
Apr 9, 2018
| @@ -36,6 +36,7 @@ | |||
| #include "lsst/afw/image/Mask.h" | |||
| #include "lsst/afw/table/io/Persistable.h" | |||
| #include "lsst/afw/geom/ellipses/Ellipse.h" | |||
| #include "lsst/afw/geom/ellipses/Quadrupole.h" | |||
There was a problem hiding this comment.
I see the use of ellipses::Quadrupole below, but I don't see anything you did that would require adding this header. Was this broken before?
There was a problem hiding this comment.
This include should have been there all along. I'm not sure how Quadrupole was getting included before, but I assume it was via some indirect path involving XYTransform.
Also remove XYTransformFactory and geom::Functor (which was only used by SeparableXYTransform, and XYTransform) Also add a pybind11 wrapper for the TransformPoint2ToPoint2 overload of SpanSet.transformedBy, which apparently got missed when the C++ was added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.