Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-14198: Modernize python in afw #349

Merged
merged 6 commits into from Apr 26, 2018
Merged

DM-14198: Modernize python in afw #349

merged 6 commits into from Apr 26, 2018

Conversation

r-owen
Copy link
Contributor

@r-owen r-owen commented Apr 26, 2018

No description provided.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing the (object) inheritance from the classes as part of the cleanup. Not critical but should be a fairly straightforward automated clean up to do.

@@ -2,10 +2,6 @@
Code that works with gdb 7.1's python pretty printing. When gdb >= 7.2 is widely available this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I'll delete it.

@r-owen
Copy link
Contributor Author

r-owen commented Apr 26, 2018

Good suggestion to remove inheritance from object. I did that.

@r-owen r-owen merged commit cbfce7a into master Apr 26, 2018
@ktlim ktlim deleted the tickets/DM-14198 branch August 25, 2018 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants