DM-14548: Make dimensionless quantities in refraction floats
#354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n value docstring
r-owen
approved these changes
May 23, 2018
python/lsst/afw/coord/refraction.py
Outdated
| densityFactor = (1. + eqn)*(dryPressure/cds.mbar)/(temperature/units.Kelvin) | ||
| eqn = float((dryPressure/cds.mbar)*(57.90E-8 - 9.3250E-4*units.Kelvin/temperature + | ||
| 0.25844*units.Kelvin**2/temperature**2.)) | ||
| densityFactor = (1. + eqn)*float(dryPressure/cds.mbar)/float(temperature/units.Kelvin) |
There was a problem hiding this comment.
From reading the astropy docs I expected to see value.to_value(units), instead of using float(value/units). For example:
dryPressure.to_value(cds.mbar)
and this seems a clear way to express what you want done.
If what you've done is a standard way to get a float in particular units, can you please point me to the appropriate docs? I realize it works, but based on reading what I found, it doesn't seem obvious to me that it should.
There was a problem hiding this comment.
Yes, that looks more clear. I'll change to to_value(units) throughout.
python/lsst/afw/coord/refraction.py
Outdated
| @@ -212,8 +212,8 @@ def humidityToPressure(weather): | |||
|
|
|||
| Returns | |||
| ------- | |||
| `float` | |||
| The water vapor pressure in millibar | |||
| `astropy.units.quantity.Quantity` | |||
There was a problem hiding this comment.
I suggest astropy.units.Quantity since that is the documented version. The existence of a quantity sub-module appears to be an internal detail of astropy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix return value docstring.