Fixed minor showCamera problems #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdswinbank
approved these changes
Aug 6, 2018
python/lsst/afw/cameraGeom/utils.py
Outdated
| if self.verbose: | ||
| log.info("Reading %s: %s" % (ccd.getId(), e)) | ||
| print("Reading %s: %s" % (ccd.getId(), err)) | ||
| log.warn("Reading %s: %s" % (ccd.getId(), err)) |
There was a problem hiding this comment.
Whether the log message gets displayed or not should be up to the logger configuration, not up to the self.verbose flag (obviously, that's not the case for the print).
There was a problem hiding this comment.
Also, it's preferable to defer the string formatting until the logger decides whether it is going to write the message or not. Remove the % and replace with standard arguments:
log.warn("Reading %s: %s", ccd.getId(), err)
python/lsst/afw/cameraGeom/utils.py
Outdated
| fileName = self.butler.get(self.type + "_filename", ccd=ccd.getId(), | ||
| **self.kwargs)[0] | ||
| im = imageFactory(fileName) | ||
| im = None |
There was a problem hiding this comment.
It's already None (per line 460).
RobertLuptonTheGood
force-pushed
the
tickets/DM-15231
branch
from
a6c6597
to
5aeaa98
Compare
RobertLuptonTheGood
force-pushed
the
tickets/DM-15231
branch
from
5aeaa98
to
fba37fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.