DM-10302 Change flux->instFlux and remove deprecated code #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-10302
branch
3 times, most recently
from
ca205d8
to
431b21c
Compare
r-owen
approved these changes
Sep 14, 2018
|
I did the InstFlux->GaussianFlux and then started doing the other one before realizing I should have made them separate commits, and it was too much work to pull them apart. |
Remove SConscript used by m4 After discussion with Jim Bosch, we agreed it was probably easier to use modern smart editors to make bulk changes to Source.h instead of having someone in the project try to remember the m4 syntax. Also, we hope to make that header much simpler by removing a bunch of the deprecated code.
These methods were marked deprecated in 2014: we can cleanup the namespace quite a bit by deleting them, and they don't appear to be used outside the afw tests.
parejkoj
force-pushed
the
tickets/DM-10302
branch
from
431b21c
to
f354dca
Compare
parejkoj
force-pushed
the
tickets/DM-10302
branch
from
5708d2e
to
0ee35a7
Compare
Increment schema version and add v1 and v2 compatibliity. Add a v2 test .fits file, to test v2 compatibility, and use it in a test.
parejkoj
force-pushed
the
tickets/DM-10302
branch
from
03a5e7d
to
3b79e2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.