DM-15613: fix BZERO for unsigned integer images and rarely write BLANK #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
approved these changes
Sep 4, 2018
TallJimbo
force-pushed
the
tickets/DM-15613
branch
from
8f70e45
to
8ce659e
Compare
This matches the value used and recognized by both native CFITSIO and astropy.io.fits.
BLANK is used to represent missing values in integer images only (NaN is always used for floating point). But our in-memory integer images can never have missing values, so the only place we need BLANK is when quantizing (for compression) a floating-point image into an integer image. Because ZBLANK is what BLANK should be after decompression, we should never write it.
ndarray::allocate does not guarantee this.
TallJimbo
force-pushed
the
tickets/DM-15613
branch
from
8ce659e
to
68ecf1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.