Tickets/dm 3105 #40
Merged
Tickets/dm 3105 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,3 +25,4 @@ | |||
| import numpy | |||
| from .imageLib import * | |||
| from .basicUtils import * | |||
| from .testUtils import * | |||
r-owen
force-pushed
the
tickets/DM-3105
branch
3 times, most recently
from
9760596
to
d75680e
Compare
Also: - Remove masksDiffer and maskedImagesDiffer (since the new asserts supersede that code) - Add a unit test for these new assertImage-like methods - Convert existing tests to use the new asserts
Change numpy.alltrue to numpy.all Remove one unused variable Modernize exception catching syntax
tests/warpExposure.py had a number of issues including: - One null test was comparing an image to itself (bug) - The EDGE mask was still being used - One test that was supposed to compare good pixels was not comparing image or variance planes - Use of numpy.alltrue is deprecated; use numpy.all instead
r-owen
force-pushed
the
tickets/DM-3105
branch
from
d75680e
to
6846ec2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.