Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-16386: Update makeLimitedFitsHeader to force floats to correct type #414

Merged
merged 4 commits into from
Nov 20, 2018
Merged

DM-16386: Update makeLimitedFitsHeader to force floats to correct type #414

merged 4 commits into from
Nov 20, 2018

Commits on Nov 11, 2018

  1. Use FITS boolean for string form not integer

    @timj
    timj committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    40d2f80 View commit details
    Browse the repository at this point in the history

  2. Force decimal point into floating point numbers 

    Without this "0.0" becomes "0" which is an integer type in FITS.
    @timj
    timj committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    f238fd7 View commit details
    Browse the repository at this point in the history

  3. Update tests for makeLimitedFitsHeader 

    * Factor out comparison code.
* Check that floating point values are numerically the same
  rather than relying on the string forms to be identical.
* Add test for single precision floats.
    @timj
    timj committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    b2fae53 View commit details
    Browse the repository at this point in the history

  4. Construct a FitsChan directly from PropertyList 

    Rather than creating a FITS header string from the PropertyList
and then parsing it to create the FitsChan, construct the
FitsChan directly from each PropertyList entry (the type is
then known direclty).
    @timj
    timj committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    dfe7ff1 View commit details
    Browse the repository at this point in the history