Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-18678: Support boost 1.69 removal of gil_all.hpp #444

Merged
merged 3 commits into from Mar 28, 2019

Conversation

timj
Copy link
Member

@timj timj commented Mar 28, 2019

No description provided.

@timj timj requested a review from TallJimbo March 28, 2019 20:09
@timj
Copy link
Member Author

timj commented Mar 28, 2019

@TallJimbo switching out boost meant I also had to explicitly load <set> in one of the include files. Since I was watching the build I also fixed the deprecation warning from pybind11.

Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for fixing the warnings as well.

I imagine we should drop the Boost version checks someday, but this is slightly safer for now?

@timj
Copy link
Member Author

timj commented Mar 28, 2019

Yes, I wanted to make sure it worked with the current boost. This lets me merge it without waiting for @fritzm to sign off on the boost update for Qserv.

@timj timj merged commit 81fa8e0 into master Mar 28, 2019
@timj timj deleted the tickets/DM-18678-afw branch March 28, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants