Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-18864: Now support UNDEF in FITS headers #446

Merged
merged 5 commits into from
Apr 3, 2019
Merged

Commits on Apr 2, 2019

  1. Configuration menu
    Copy the full SHA
    f33bc28 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    78bb7c4 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2019

  1. Configuration menu
    Copy the full SHA
    6551cff View commit details
    Browse the repository at this point in the history
  2. Add workaround for PropertyX lack of support for undefined arrays

    PropertySet (and List) can handle arrays of undefined values
    but can not handle the addition of an undefined value to an
    existing array, or the addition of a good value to an
    undefined array.
    
    With this change we make the following allowances when reading
    FITS headers that may have multiple keywords, some of which
    may be undef:
    
    * If a defined value is being added to a key that exists but
      is undefined, the defined value will override.
    * If an undef value is being added to a key that exists but
      is has one or more defined values, the undef value will be
      dropped.
    
    A test has been added to ensure that this is happening.
    timj committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    35287dd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    33f9b24 View commit details
    Browse the repository at this point in the history