DM-19575: Add Storable mixin to ExposureInfo components #465
Commits on Jun 7, 2019
-
-
Remove pybind11 wrappers for Storable.
Wrapping Storable's optional methods leads to a confusing Python API. In practice, any subclass of Storable that is, for example, printable or hashable will provide its own wrappers for those operations anyway.
-
Clarify importance of Storable::clone.
Non-cloneable Storables cannot be used (practically) with PolymorphicValue, and therefore with Key<T extends Storable>.
-
The requirement to return a smart pointer to Storable made it difficult to use Storable as a mixin for classes that already have a clone method. Renaming the method minimizes the number of times that cloneStorable must be implemented (typically only in the direct subclass of Storable).
-
Make Storable::cloneStorable return shared_ptr.
While unique_ptr is a better return type for a factory method, a unique_ptr return cannot be implemented in terms of a shared_ptr return (though the reverse is true), and our existing classes cannot be modified to clone by unique_ptr without running into a pybind11 bug. At present it looks like the pybind11 team is leaning towards forbidding such code rather than supporting unique_ptr to shared_ptr conversion.
-
Equals was returning `false` for comparisons to self.
-
-
Add helper template for implementing Storable::equals.
The template handles the most common behavior, where an object of a class implementing Storable is comparable to other objects of the same class, but should always be unequal to other Storables.
-
-
-
-
-
-
-
-
-
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.