Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-21129: Improve "unsupported operand types" error for afwImage arithmetic #483

Merged
merged 1 commit into from Aug 30, 2019

Conversation

PaulPrice
Copy link
Contributor

No description provided.

Copy link
Contributor

@mrawls mrawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect, and the tests are very clear, thank you so much!

People get confused when they get a weird error after
writing 'image1 + image2', so provide a more helpful
error messasge for such operations.
Copy link
Contributor

@mrawls mrawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me a little bit to parse how the wrapper is supposed to work, but I don't have a suggestion for how to make it clearer (besides getting rid of ImageSlices altogether of course). If this works and passes Jenkins, please go ahead with it.

@PaulPrice PaulPrice merged commit 2c36efe into master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants