DM-21181: Add getLocalCalibration function to photoCalib. #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Sep 13, 2019
|
I mean, I change the commit message? It just has all the individual commits squashed in but the "title" reflects what is actually going in there. How would you recommend fixing it? |
|
Looks to me like the commit message here should simply be `Add getLocalCalibration function to photoCalib' — the rest is unnecessary. |
morriscb
force-pushed
the
tickets/DM-21181
branch
from
0f28e34
to
b9c717b
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add localCalib unittest.
Fix flux names in local calib tests.
Add getLocalCalibration function to header.
Add pybindings.
Add test comment.
Remove superfluous test.
Debug getLocalCalibration
clang-format of .h file