DM-19582: Add cross-language GenericMap unit tests #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C++ considers int, long, and long long fundamentally different types (even though in practice two of the three will be identical), so one of the three does not map correctly to either int32_t or int64_t.
Inexact matching was previously documented only in the CLO announcement and the design documentation.
TallJimbo
approved these changes
Sep 18, 2019
This commit fixes a bug where Storable values could not be read from Python.
The garbage collection bug is a significant restriction on Storable, and providing a non-passing unit test makes this fact more self-documenting.
kfindeisen
force-pushed
the
tickets/DM-19582
branch
from
1ec8605
to
d7581c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests to
GenericMapthat pass objects from Python to C++ and/or vice versa. This exposes behavior that was not adequately tested with previous tests.Bugs fixed:
afwwith Scons no longer issues an "ignoring a non-existent file" warningGenericMap's policy on type conversions is now explicitly described in the API docsint, nor Python floats tofloat, when inserted into aGenericMap(but see DM-21268, below)Storablevalues (i.e., non-pointers) can now be retrieved from aGenericMapin PythonBugs deferred:
GenericMap's weakly-typedinsertmethod turns C-strings intobool[DM-21216].GenericMapcannot consistently handle integers and floats from Python, particularly Numpy's explicit-length types [DM-21268].Storablemay be prematurely garbage-collected [DM-21314].