DM-21314: Investigate GC problems with Storable #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Nov 5, 2019
| std::shared_ptr<Storable> cloneStorable() const override { | ||
| /* __deepcopy__ takes an optional dict, but PYBIND11_OVERLOAD_* doesn't | ||
| * allow translation between different argument lists in C++ and Python | ||
| */ |
There was a problem hiding this comment.
Are you saying this will fail if __deepcopy__ is called with that argument? (Not unreasonable - using it would at least be significantly more complex, if it's even possible - just asking for clarification in the comment.)
There was a problem hiding this comment.
I'm not sure if this answers your question, but the macro will not compile if you give it arguments (like py::none() or py::dict()) that are not present in cloneStorable's argument list.
kfindeisen
force-pushed
the
tickets/DM-21314
branch
from
57e2b73
to
b78ed86
Compare
The fix involves manually keeping track of the Python "half" of an object using a custom holder object.
The tests show that subclasses work correctly if and only if their closest C++ base uses PySharedPtr.
kfindeisen
force-pushed
the
tickets/DM-21314
branch
from
3a1c23d
to
4ef85b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that prevented
Storableobjects from being usable unless they were continuously referenced by Python code. The fix depends on lsst/utils#75.It also implements and tests cloning of Python
Storables, which was left unsupported due to an oversight.