Support from __future__ import division #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for classes such as Extension that support operator/ and/or operator/= and change unit tests to use it
| @@ -103,7 +104,6 @@ def testChebyshev1Function1D(self): | |||
| """A test for Chebyshev1Function1D""" | |||
| maxOrder = 6 | |||
| deltaParam = 0.3 | |||
| allParams = numpy.arange(deltaParam, deltaParam * (maxOrder + 1) + (deltaParam / 2.0), deltaParam) | |||
There was a problem hiding this comment.
This was unused? It would help to put cleanup in a different commit from the implementation of the ticket.
Several obvious checks were commented out because they were applied to cloned functions, which don't support the extra methods of function subclasses. An alternative would be to cast the clone to the appropriate type, but the current tests suffice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for classes such as Extension that support operator/ and/or operator/=
and change unit tests to use it