Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-23178: Update code to use f strings #512

Merged
merged 1 commit into from Jan 24, 2020
Merged

DM-23178: Update code to use f strings #512

merged 1 commit into from Jan 24, 2020

Conversation

r-owen
Copy link
Contributor

@r-owen r-owen commented Jan 24, 2020

No description provided.

timj
timj approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Code is easier to read and the lines are shorter. I'm okay to merge although can you check there isn't someone actively working on an afw ticket that would suddenly be hit with a lot of work when they rebase?

@r-owen
Copy link
Contributor Author

r-owen commented Jan 24, 2020

Thank you. I already did that check. I found only one active ticket branch with a minor change that would not be affected at all.

@r-owen r-owen merged commit fe24ee5 into master Jan 24, 2020
@r-owen r-owen deleted the tickets/DM-23178 branch January 24, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r-owen @timj