capitalize on read and warn, warn when keywords are capitalized on write for fits files #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add case warnings for read/write with cftisio>=3.38
ktlim
approved these changes
Apr 23, 2020
Co-Authored-By: Kian-Tat Lim <ktl@slac.stanford.edu>
Co-Authored-By: Kian-Tat Lim <ktl@slac.stanford.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading from fits files from cfitsio>=3.38, cfitsio capitalizes keywords in some scenarios but not all. This PR normalizes capitalization when reading in all of those cases and warns the user this action has happened.
When writing to fits files, cfitsio>=3.38 will capitalize all keywords, including long ones. This PR will warn the user that this will be happening.