Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop WARN to DEBUG on uppercasing keywords on read #530

Merged
merged 2 commits into from May 19, 2020
Merged

Drop WARN to DEBUG on uppercasing keywords on read #530

merged 2 commits into from May 19, 2020

Conversation

brianv0
Copy link
Contributor

@brianv0 brianv0 commented May 19, 2020

When reading a fits keyword, we log only debug messages due to
proliferation of old files.

@brianv0
Drop WARN to DEBUG on uppercasing keywords on read
2fb8a7f 
When reading a fits keyword, we log only debug messages due to
proliferation of old files.
@brianv0 brianv0 requested a review from erykoff May 19, 2020 18:30
erykoff
erykoff approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except the indentation of the following lines...? (I don't know c++ linting, though).

src/fits.cc Outdated Show resolved Hide resolved
@brianv0 brianv0 merged commit f0e7235 into master May 19, 2020
@timj timj deleted the tickets/DM-24993 branch February 18, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brianv0 @erykoff