DM-6981: Implement assignment to Flag columns in the pybind11 layer. #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only works when the key is a `str` name or a `Key` instance; because support for slice assignment for all other fields currently delegates so much to NumPy, it's a lot harder to make that work for Flags.
erykoff
approved these changes
May 26, 2020
| @@ -799,6 +799,26 @@ def testDelete(self): | |||
| with self.assertRaises(IndexError): | |||
| del catalog[50] | |||
|
|
|||
| def testSetFlagColumn(self): | |||
| schema = lsst.afw.table.Schema() | |||
| key = schema.addField("a", type="Flag", doc="doc for 'a'") | |||
There was a problem hiding this comment.
I wonder if we should add another layer to this test, with a b flag as well as an a flag, to ensure that the bit-packing behind the scenes is doing what we think it should be doing. (However, I did confirm that this does work with multiple flags).
There was a problem hiding this comment.
The bit-packing is implemented in a level below this that has its own tests, so I think one is sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only works when the key is a
strname or aKeyinstance; because support for slice assignment for all other fields currently delegates so much to NumPy, it's a lot harder to make that work for Flags.