DM-26260: ExposureFitsReader should not read the mask/variance if they are missing #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Aug 6, 2020
src/image/MaskedImageFitsReader.cc
Outdated
| LSST_EXCEPT_ADD(e, "Reading Mask"); | ||
| throw e; | ||
| } | ||
| LOGL_WARN(_log, "Mask unreadable (%s); using default", e.what()); |
There was a problem hiding this comment.
Looking at this code in isolation, it seems like it'd be appropriate to emit this warning when _maskReader._fitsFile is null, too. But in the higher-level context of the ticket, it seems we load Exposure or MaskedImage objects from single-plane FITS files all the the time, and don't want warnings when we do that, so maybe the right fix is to remove the warning from both code paths?
In any case, we should probably obey the needAllHdus logic when _maskFitsReader._fitsFile is null, and throw an exception. I don't think that's used very often (if at all), but it'd certainly be confusing to pass needAllHdus=True and then silently only get the image plane loaded.
If a compressed single image FITS file is read an attempt is made to read the mask and variance because additional extensions can be present. This will fail because they aren't really masks but on failing an assumption is made that the file was registered with the reader. This is not set because nextHdu can return a null pointer. Therefore add protections such that we do not attempt to read the mask/variance if the fits file attribute is null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a compressed single image FITS file is read an attempt is made to read the mask and variance because additional extensions can be present. This will fail because they aren't really masks but on failing an assumption is made that the file
was registered with the reader. This is not set because nextHdu can return a null pointer. Therefore add protections such that we do not attempt to read the mask/variance if the fits file attribute is null.