DM-25253: Warn when weights are ignored in statisticsStack #537
Conversation
| LOGLS_WARN(_log, | ||
| "Weights passed on to statisticsStack are ignored as sctrl.getWeighted() is False." | ||
| "Set sctrl.setWeighted(True) for them to be used."); | ||
| } |
There was a problem hiding this comment.
You can just use LOG_WARN here. The LOGL_ and LOGLS_ variants are just different ways of doing string formatting on the message, but you're not doing any here.
There was a problem hiding this comment.
The use of LOG_WARN appears pretty minimal, with no occurrence except in its own unit test. Furthermore, I'm not sure if we want this to go into a default logger if there is one since it appears multiple times. So, we use LOGL_WARN and log it into the appropriate log file instead.
There was a problem hiding this comment.
Sorry, I should have suggested LOGL_WARN, not LOG_WARN; I hadn't realized that the "L" suffix controlled whether a log object was accepted and only the "S" suffix controlled the string formatting. But what you've merged is fine.
MorganSchmitz
force-pushed
the
tickets/DM-25253
branch
2 times, most recently
from
8a7c2ba
to
e9c3997
Compare
MorganSchmitz
force-pushed
the
tickets/DM-25253
branch
from
e9c3997
to
11b1cca
Compare
Jenkins run #32492.
Jira ticket.
Paircoded with @arunkannawadi!