DM-5280: Port afw changesets to LSST #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,30 +1,86 @@ | |||
| import numpy as np | |||
There was a problem hiding this comment.
Please add the LSST legal boilerplate.
PaulPrice
force-pushed
the
tickets/DM-5280
branch
3 times, most recently
from
d3603ad
to
f3f86d8
Compare
PaulPrice
force-pushed
the
tickets/DM-5280
branch
from
f3f86d8
to
12493ac
Compare
Linear was already available with Q=0, but this way is clearer; the default is to use min/max limits. I also added AsinhZScaleMapping which uses the zscale code to set the stretch. I did not port the log mappings, as the C++ is not really something I'd like to see in the long-term stack (e.g. reinterpret_casts between ints and doubles). It would be easy to add a LogMapper in pure python, and if this is needed please open a new issue. The ZScale code comes from Mineo-san's fitsthumb, but doesn't give quite the same upper limit as ds9. I'm not sure where the discrepancy is, but I don't think it matters.
PaulPrice
force-pushed
the
tickets/DM-5280
branch
3 times, most recently
from
7fc2a87
to
a5df69e
Compare
…SC-1207 N.b. requires scipy which is not a dependency of afw.
This fixes the problem in setting nImage (wasn't being done until makeMosaic was called), while not hurting the API.
PaulPrice
force-pushed
the
tickets/DM-5280
branch
from
a5df69e
to
9aa1658
Compare
N.b. added some missing tests on matchXY, although it is unchanged by this changeset
see discussion in HSC HipChat room, 2:10am, 2015-05-09
Use a common default Q value (RHL recommends 8-10, chose 8). Use 'dataRange' instead of 'range' (which shadows a builtin). Disable numpy warnings in default mapIntensityToUint8.
PaulPrice
force-pushed
the
tickets/DM-5280
branch
from
81d9ce2
to
e21f3e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review of cherry-picked HSC commits to be merged.