Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-22114: Remove deprecated makeDistortedTanWcs #541

Merged
merged 2 commits into from Oct 29, 2020

Conversation

arunkannawadi
Copy link
Member

@arunkannawadi arunkannawadi commented Oct 8, 2020

This PR removes the function makeDistortedTanWcs and merges its unit tests with those of computePixelToDistortedPixel.

@arunkannawadi arunkannawadi changed the title Remove deprecated makeDistortedTanWcs tickets/DM-22114: Remove deprecated makeDistortedTanWcs Oct 8, 2020
@arunkannawadi arunkannawadi changed the title tickets/DM-22114: Remove deprecated makeDistortedTanWcs DM-22114: Remove deprecated makeDistortedTanWcs Oct 8, 2020
Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused: why didn't you keep the existing ComputePixelToDistortedPixelTestCase and remove the MakeDistortedTanWcsTestCase class instead? It's hard to tell with this diff whether the new class is exactly the same as the deleted one or not.

@arunkannawadi
Copy link
Member Author

The messy diff happens to be due to git trying to behave too smart, it looks like. I unstaged the previous changes and removed the MakeDistortedTanWcsTestCase completely and edited the ComputePixelToDistortedPixelTestCase, but because the line numbers coincide, git really thinks I edited former one and deleted the latter one. In any case, the git diffs are messy either ways the two test cases are merged.

@arunkannawadi arunkannawadi force-pushed the tickets/DM-22114 branch 3 times, most recently from e3bec22 to bf3c8df Compare October 26, 2020 03:12
@arunkannawadi
Copy link
Member Author

Okay, I've split the changes into two commits that make more sense logically. The PR diff is still messy as before, but the commit diffs might be helpful to see the differences.

Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment about a docstring, but otherwise this looks good. Thank you for the detailed comments in the new tests regarding how you generate and apply the transforms, they are very helpful.

tests/test_wcsUtils.py Show resolved Hide resolved
@arunkannawadi arunkannawadi merged commit 1d6dc99 into master Oct 29, 2020
@timj timj deleted the tickets/DM-22114 branch February 18, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants