DM-21333: Implement afw.image.Filter replacement(s) #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
approved these changes
Oct 27, 2020
Comment on lines
+136
to
+141
| // A separate boolean leads to easier implementations (at the cost of more | ||
| // memory) than a unique_ptr<string>. | ||
| // _band and _physical are part of the object state iff _hasBand and _hasPhysical, respectively | ||
| bool _hasBand, _hasPhysical; | ||
| std::string _band, _physical; |
There was a problem hiding this comment.
Just for my education - I presume that label cannot be empty for actual physical/band, would it simplify things if you use empty string instead of separate bool flag for each?
There was a problem hiding this comment.
While I can't think of a legitimate use for an actual empty string as either name, I distrust magic values. This approach leads to less surprising behavior, I think.
|
|
||
| #ifndef DOXYGEN | ||
| class FilterLabel; | ||
| namespace impl { |
There was a problem hiding this comment.
I think people usually use detail namespace for implementation-level global names.
There was a problem hiding this comment.
The developer guide said to use impl in this case.
This class has factory methods and getters, but no other functionality.
Though in principle these could be tested separately, doing so would greatly increase the proportion of tests that use factories instead of keyword for construction, and I want to encourage the latter as the natural Python interface.
Since FilterLabel is a value-like object, all four methods are appropriate. Hashing is non-trivial because some members are part of the object state only some of the time; I've added a C++ unit test to check this.
kfindeisen
force-pushed
the
tickets/DM-21333
branch
from
547cbe1
to
2ee1984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
FilterLabelclass and unit-tests its functionality. Integration withExposureis not yet supported, and will be added later.