DM-27169: Use FilterLabel in Exposure/ExposureInfo #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 26, 2020
kfindeisen
force-pushed
the
tickets/DM-27169
branch
4 times, most recently
from
11db32d
to
f4e35a9
Compare
parejkoj
reviewed
Dec 7, 2020
| @@ -223,12 +413,9 @@ class ExposureFitsReader::ArchiveReader { | |||
|
|
|||
| // Not safe to call getAll if a component cannot be unpersisted | |||
| // Instead, look for the archives registered in the metadata | |||
There was a problem hiding this comment.
Given how you reworked this with readComponent, is this comment still necessary?
There was a problem hiding this comment.
I think so? If I could call getAll, I wouldn't need to manually build up a map of results.
kfindeisen
force-pushed
the
tickets/DM-27169
branch
from
f4e35a9
to
7a33252
Compare
Add methods and tests analogous to the old Filter support. FilterLabel automatically persisted through generic component code.
This change gives ArchiveReader the flexibility to read old ExposureInfo components using either the legacy system or the generic component system.
This change makes it possible to read one generic component without needing to iterate over the rest.
The code lets Exposure files based on Filter be read as Exposures with a FilterLabel. Filter is also read because some Exposure methods still need it.
The new code can take either a filter or a name as input.
Separate Filter storage removed from ExposureInfo; now backed by (generic) FilterLabel.
Filters are now stored only as ExposureInfo components. Add backwards-compatibility test for ExposureInfo version 2.
Other Stack code assumes Filter.getName() returns the afw_name when it's needed to disambiguate filters (i.e., HSC-R2 and HSC-I2).
kfindeisen
force-pushed
the
tickets/DM-27169
branch
from
7a33252
to
b9278ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces both the internal state and the persistence format of
Exposureto useFilterLabelinstead ofFilter. Accessors forFilterremain for backwards-compatibility, but are re-implemented in terms ofFilterLabel. I've also done some refactoring of the generic component code that should make it easier to apply in the future.