DM-28004: ExposureInfo may persist dummy FilterLabels #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
reviewed
Dec 14, 2020
There was a problem hiding this comment.
My only question is whether we could have a test here (or in obs_base?) that confirms/demonstrates this behavior. If that requires persisting a FITS file without a Filter defined, then don't bother, but if it's a trivial test?
Also, does this require changing the docstrings for ExposureInfo or the FitsReader?
A quick skim of the docs (and a reminder that the guts are a StorableMap now) suggests not, but I'm not positive.
The check's previous location in the ExposureInfo constructor allowed some old Filter code to bypass it, storing "unknown" FilterLabels.
kfindeisen
force-pushed
the
tickets/DM-28004
branch
from
d9c8832
to
f2480be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces the convention that
ExposureInfo::getFilter() == Filter()corresponds toExposureInfo::getFilterLabel() == nullptrat the translator level rather than theExposureInfoconstructor level. This prevents spurious "_unknown_"FilterLabelsfrom getting persisted as part of newExposures.