DM-27170: Deprecate and phase out afw::image::Filter #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
approved these changes
Jan 5, 2021
parejkoj
force-pushed
the
tickets/DM-27170
branch
from
3564da5
to
c9340ae
Compare
parejkoj
force-pushed
the
tickets/DM-27170
branch
from
c9340ae
to
6f251c1
Compare
parejkoj
force-pushed
the
tickets/DM-27170
branch
2 times, most recently
from
c149fb0
to
ab1c750
Compare
|
@kfindeisen : I changed how I deprecated FilterProperty in a new commit: it seems to have fixed the bug I was getting building afw in the new conda environment (seem #dm-build-problems). If you're happy with it, I'll squash it. |
kfindeisen
approved these changes
Jan 28, 2021
|
Good point: I just did that in the latest commit. It's a little clunky, but seems to do the trick. What do you think? |
Mark Filter/FilterProperty and their static members deprecated using a non-standard approachin python due to some sort of bug in the deprecation system that we haven't exactly pinned down yet.
parejkoj
force-pushed
the
tickets/DM-27170
branch
from
fb0a2d8
to
06f682d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.