DM-28717: Allow for Stamps formatter to handle bbox #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
reviewed
Mar 3, 2021
| if options.exists("llcX"): | ||
| if "bbox" in options.keys(): | ||
| bbox = options["bbox"] | ||
| elif isinstance(options, PropertySet) and options.exists("llcX"): |
There was a problem hiding this comment.
This should support dict and not be restricted to PropertySet. You can use in so this will work just like the check for bbox above:
elif "llcx" in options:| @@ -52,6 +53,9 @@ def imageReadFitsWithOptions(cls, source, options): | |||
| - imageOrigin: one of "LOCAL" or "PARENT" (has no effect unless | |||
| a bbox is specified by llcX, etc.) | |||
|
|
|||
| Alternatively, a bounding box () can be passed on with the | |||
| ``"bbox"'' key. | |||
There was a problem hiding this comment.
You should document what type the value should be.
| origin = ImageOrigin.PARENT | ||
| else: | ||
| raise RuntimeError("Unknown ImageOrigin type {}".format(originStr)) | ||
| if options.exists("imageOrigin"): |
There was a problem hiding this comment.
Change this to be dict compatible as if "imageOrigin" in options
| @@ -25,6 +25,7 @@ | |||
| import lsst.geom | |||
| from lsst.log import Log | |||
| from lsst.afw.fits import ImageWriteOptions | |||
| from lsst.daf.base import PropertySet | |||
There was a problem hiding this comment.
This line is not needed if you use the dict compatibility interface of PropertySet
MorganSchmitz
force-pushed
the
tickets/DM-28717
branch
2 times, most recently
from
f098e33
to
f9232ea
Compare
So the correct exception is caught when options are passed on as a dict instead of a PropertySet. Also ensure subTest receives a str.
MorganSchmitz
force-pushed
the
tickets/DM-28717
branch
from
f9232ea
to
c4c9047
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of several PRs for DM-28717, the others being in daf_butler, meas_algorithms and obs_base.