Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-6278: clean up Image.cc, use PixelT for calculations #577

Merged
merged 1 commit into from Oct 7, 2021
Merged

DM-6278: clean up Image.cc, use PixelT for calculations #577

merged 1 commit into from Oct 7, 2021

Conversation

mwittgen
Copy link
Contributor

@mwittgen mwittgen commented Apr 1, 2021

…rnally

@mwittgen mwittgen force-pushed the tickets/DM-6278 branch 2 times, most recently from 892b4cb to 1c109dd Compare May 23, 2021 23:05
erykoff
erykoff approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the PR needs to be shortened, otherwise looks good.

@mwittgen mwittgen changed the title DM-6278: clean up Image.cc, use PixelT for calculations, don't use double inte… DM-6278: clean up Image.cc, use PixelT for calculations Oct 7, 2021
@mwittgen mwittgen merged commit 00d26d6 into master Oct 7, 2021
@mwittgen mwittgen deleted the tickets/DM-6278 branch October 7, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mwittgen @erykoff