Replace assert with exception for invalid argument #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkannawadi
force-pushed
the
tickets/DM-29069
branch
2 times, most recently
from
c4355d6
to
d87ea0c
Compare
MorganSchmitz
approved these changes
May 6, 2021
The methods `setNumIter` and `setNumSigmaClip` must throw an exception if the input parameters are invalid instead of asserting that they are valid.
arunkannawadi
force-pushed
the
tickets/DM-29069
branch
from
d87ea0c
to
7befe53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods
setNumIterandsetNumSigmaClipmust throw an exceptionif the input parameters are invalid instead of asserting that they are
valid.