Use and enforce Astropy compliant units #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pschella
changed the title
| "saturation value, in ADU", | ||
| "ADU"); | ||
| "saturation value", | ||
| "adu"); |
There was a problem hiding this comment.
As I just posted on the RFC, I don't think we want to use adu in some places and count in others, since they mean the same thing. But I'm not sure which is preferred.
(I'm aware this was a preexisting inconsistency, but I'd like to address it on this issue).
pschella
changed the title
added 2 commits
May 10, 2016 17:05
The Schema.addField method now first attempts to construct an astropy.units.Unit object from the provided unit string. This will raise a ValueError if the string is non-compliant. The optional keyword argument parse_strict from astropy.units.Unit is also added to addField. It has three levels: 'raise' (default), 'warn' and 'silent'. The latter causes any unit string to be accepted. Also add Schema.checkUnits to allow a full Shema to be validated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.