DM-30426: New Psf bbox methods #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
approved these changes
Jun 7, 2021
| @@ -165,6 +171,12 @@ std::shared_ptr<Psf::Image> Psf::doComputeImage(lsst::geom::Point2D const &posit | |||
| return recenterKernelImage(im, position); | |||
| } | |||
|
|
|||
| lsst::geom::Box2I Psf::doComputeImageBBox(lsst::geom::Point2D const& position, | |||
| image::Color const& color) const { | |||
| std::shared_ptr<Psf::Image> im = computeImage(position, color, INTERNAL); | |||
There was a problem hiding this comment.
I'm concerned that this implementation is inefficient. At the very least you need to document this with a big red warning sign. It may be that we're not bitten terribly because of the caching, but I think you should also put some effort into implementing this method properly and efficiently in the subclasses in meas_algorithms.
jmeyers314
force-pushed
the
tickets/DM-30426
branch
from
80e9aa8
to
e10ff4c
Compare
These are synonyms for Psf::computeImage::getBBox and Psf::computeKernelImage::getBBox, but may be overridden for speed by Psf subclasses.
jmeyers314
force-pushed
the
tickets/DM-30426
branch
from
e10ff4c
to
f3960e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
computeImageBBox, which returnsPsf->computeImage()->getBBox(), but allows Psf subclasses to implement this without requiring the intermediate call tocomputeImage().Also adds
computeKernelBBoxfor symmetry, though this is equal tocomputeBBox.