DM-11419: Allow larger than 2GB offsets in tables - use std::size_t for offsets… #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
approved these changes
Aug 4, 2021
tests/test_ticket11419.py
Outdated
Comment on lines
32
to
33
| self.schema.addField('test1', type='ArrayF', size=370010025) | ||
| self.schema.addField('test2', type='ArrayF', size=370010025) |
There was a problem hiding this comment.
I guess this covers case when size of two fields is larger than 2GB. Maybe add a case when single field exceeds 2GB too?
mwittgen
force-pushed
the
tickets/DM-11419
branch
2 times, most recently
from
a773fb9
to
db38b56
Compare
mwittgen
force-pushed
the
tickets/DM-11419
branch
from
db38b56
to
186c2f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use std::size_t for offsets and sizes