Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the intended error estimate for clipped variance in Statistics::getResult #602

Closed
wants to merge 1 commit into from
Closed

Conversation

jjbuchanan
Copy link

No description provided.

@jjbuchanan jjbuchanan changed the title Use the intended error estimate for Statistics::getResult case VARIANCECLIP Use the intended error estimate for clipped variance in Statistics::getResult Jul 28, 2021
@parejkoj
Copy link
Contributor

parejkoj commented Aug 9, 2021

tests/test_statistics.py:testVarianceClip() should test for this, but it doesn't check the errors. Would you be able to provide an added python test for this calculation? I'm not sure if the errors on the clipped variance are really just sqrt(second): see the todo comment in Statistics.h::getResult().

The test would be modified something like this:

varianceClip = afwMath.makeStatistics(image, afwMath.VARIANCECLIP | afwMath.ERRORS).getResult()
self.assertAlmostEqual(varianceClip[0], self.clippedVariance3*std**2, delta=2*delta)
expectedVarianceError = ???
self.assertAlmostEqual(varianceClip[1], expectedVarianceError)

We should also have a similar test for the STDEVCLIP errors above this section in the same method.

@parejkoj
Copy link
Contributor

parejkoj commented Aug 9, 2021

Note that I'm tracking this on Jira here: https://jira.lsstcorp.org/browse/DM-31358

@jjbuchanan jjbuchanan closed this by deleting the head repository Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants